hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17056) Remove checked in PB generated files
Date Fri, 11 Nov 2016 06:49:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656330#comment-15656330
] 

stack commented on HBASE-17056:
-------------------------------

If we don't check in the shaded and generated files, then IDEs will report classes as not
findable since they are not in our src tree. To get them, you'll need to run a mvn build first.
That ok to require of our IDE users?

On timing, for the smaller modules where there five or six protos -- e.g. hbase-endpoint --
then the build time for a 'clean install -DskipTests' goes from 5 seconds to 7 seconds. Acceptable
I'd say.

On checkStaleness, it is set already but I'd think that rather than generate the protos into
our src tree, instead, we'd generate under target dir at pre-compile and then tell the compiler
to pick up the protos along w/ src/main/java when it goes to compile. Means that a mvn clean
will remove the generated protos.  But no protos dirtying our src? (But IDEs will report missing
files when you look at endpoints, etc.)

> Remove checked in PB generated files 
> -------------------------------------
>
>                 Key: HBASE-17056
>                 URL: https://issues.apache.org/jira/browse/HBASE-17056
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0
>
>
> Now that we have the new PB maven plugin, there is no need to have the PB files checked
in to the repo. The reason we did that was to ease up developer env setup. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message