hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17048) Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer in FanOutOneBlockAsyncDFSOutputHelper
Date Fri, 25 Nov 2016 07:38:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695110#comment-15695110
] 

ramkrishna.s.vasudevan commented on HBASE-17048:
------------------------------------------------

Actually we already use buf.readableBytes. That is enough I believe as in first patch. But
I felt since we are adding a class it will be better to pass on the bytesWritten as and when
we write. 
If we directly use buf.readableBytes then I think may be we don't need this extra new class
itself and only add this guess() as an internal private API in the FanOutOneBlockAsyncDFSOutput.

> Introduce a helper class to calcuate suitable ByteBuf size when allocating send buffer
in FanOutOneBlockAsyncDFSOutputHelper
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17048
>                 URL: https://issues.apache.org/jira/browse/HBASE-17048
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17012_3.patch, HBASE-17048.patch, HBASE-17048_1.patch
>
>
> As [~ram_krish] mentioned in HBASE-17021
> https://issues.apache.org/jira/browse/HBASE-17021?focusedCommentId=15646938&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15646938
> The default ByteBuf size is 256B which is too small.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message