hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17033) LogRoller makes a lot of allocations unnecessarily
Date Tue, 08 Nov 2016 01:55:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646150#comment-15646150
] 

Hudson commented on HBASE-17033:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.4 #523 (See [https://builds.apache.org/job/HBase-1.4/523/])
HBASE-17033 LogRoller makes a lot of allocations unnecessarily (enis: rev b99690ac6b258962e53bd36fba1b20df18fabc78)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java


> LogRoller makes a lot of allocations unnecessarily
> --------------------------------------------------
>
>                 Key: HBASE-17033
>                 URL: https://issues.apache.org/jira/browse/HBASE-17033
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: Screen Shot 2016-11-04 at 6.39.00 PM.png, hbase-17033_v1.patch
>
>
> I was looking at the other allocations for HBASE-17017. Seems that log roller thread
allocates 200MB for ~7% of the TLAB space. This is a lot of allocations. 
> I think the reason is this: 
> {code}
> while (true) {
>         if (this.safePointAttainedLatch.await(1, TimeUnit.NANOSECONDS)) {
>           break;
>         }
>         if (syncFuture.isThrowable()) {
>           throw new FailedSyncBeforeLogCloseException(syncFuture.getThrowable());
>         }
>       }
> {code}
> This busy wait is causing a lot allocations because the thread is added to the waiting
list. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message