hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17012) Handle Offheap cells in CompressedKvEncoder
Date Tue, 29 Nov 2016 12:01:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705105#comment-15705105
] 

Anoop Sam John commented on HBASE-17012:
----------------------------------------

Added some minor comments in RB.  
+1.  Can fix those on commit.

> Handle Offheap cells in CompressedKvEncoder
> -------------------------------------------
>
>                 Key: HBASE-17012
>                 URL: https://issues.apache.org/jira/browse/HBASE-17012
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Anoop Sam John
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17012_1.patch, HBASE-17012_2.patch, HBASE-17012_3.patch, HBASE-17012_4.patch,
HBASE-17012_5.patch
>
>
> When we deal with off heap cells we will end up copying Cell components on heap
> {code}
> public void write(Cell cell) throws IOException {
> .................
>       write(cell.getRowArray(), cell.getRowOffset(), cell.getRowLength(), compression.rowDict);
>       write(cell.getFamilyArray(), cell.getFamilyOffset(), cell.getFamilyLength(),
>           compression.familyDict);
>       write(cell.getQualifierArray(), cell.getQualifierOffset(), cell.getQualifierLength(),
>           compression.qualifierDict);
> ......
>       out.write(cell.getValueArray(), cell.getValueOffset(), cell.getValueLength());
> ...
> {code}
> We need to avoid this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message