hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16991) Make the initialization of AsyncConnection asynchronous
Date Wed, 02 Nov 2016 11:58:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628732#comment-15628732
] 

Yu Li commented on HBASE-16991:
-------------------------------

It seems to me in UT cases we are still using blocking mode (future.get) although we already
have {{createAsyncConnection}} returning a CompletableFuture, mind take use of it and make
the UT an example of fully asynchronous?

Another question is that for blocking mode we no longer cache the connections for customer
and depend on recommending user to only call create connection method once inside a single
jvm process (honestly I don't even think this is a good idea...), but shall we follow the
same pattern for async connections? If so we always have to block at the first time of getting
connection although the implementation is non-blocking?

Thanks.

> Make the initialization of AsyncConnection asynchronous
> -------------------------------------------------------
>
>                 Key: HBASE-16991
>                 URL: https://issues.apache.org/jira/browse/HBASE-16991
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16991.patch
>
>
> Now the ConnectionFactory.createAsyncConnection is still blocking. We should make it
return a CompletableFuture to make the async client fully asynchronous.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message