hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16982) Better integrate Apache CLI in AbstractHBaseTool
Date Wed, 02 Nov 2016 05:21:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627778#comment-15627778
] 

stack commented on HBASE-16982:
-------------------------------

All looks good.

When a single-dash, single letter, that takes an argument, we delimit name from argument with
a space?

When double-dash, need an equals between name and value? If so, all is good.

Whats the patch do? Puts Apache CLI everywhere?

> Better integrate Apache CLI in AbstractHBaseTool
> ------------------------------------------------
>
>                 Key: HBASE-16982
>                 URL: https://issues.apache.org/jira/browse/HBASE-16982
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-16982.master.001.patch
>
>
> Problem
> 1. Inconsistencies in our user facing tools.
> - options:
>     start with single/double dash
>     words separated by dash or underscore or just joined together
>     someplace use '=' to separate value, other use space (ExportSnapshot vs HashTable)
> - Description
>   Manually formatting options and their descriptions in printUsage()
>   Inconsistant formatting, sometimes even weird.
>   Incomplete. Sometimes people forget to add new option to description
> 2. Manual parsing of options (those huge if-else loops iterating over args)
> Solution
> Use Apache CLI
> - It has various validations for option names which'll fix first set of issues.
> - using AbstractHBaseTool's print usage function will ensure consistent formatting (although
we loose the power to order the options)
> - If we enforce the method of defining options as in patch, it's highly unlikely to forget
adding description.
> - CLI parses the options for us.
> Using Apache CLI when writing new tools is straight forward, but it's not easy when porting
exiting tools since some option names are not valid as per CLI's validation.
> New method, processOldArgs(), will allow to port these tools in a backward compatible
manner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message