hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16972) Log more details for Scan#next request when responseTooSlow
Date Tue, 01 Nov 2016 08:56:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624834#comment-15624834
] 

Yu Li commented on HBASE-16972:
-------------------------------

I'm afraid we only have such information for openScanner call and don't for scan.next, and
I believe the above trace log is for openScanner. I'm referring to {{ScannerCallable#rpcCall}}:
{code}
      if (this.scannerId == -1L) {
        this.scannerId = openScanner();
      } else {
        Result [] rrs = null;
        ScanRequest request = null;
        // Reset the heartbeat flag prior to each RPC in case an exception is thrown by the
server
        setHeartbeatMessage(false);
        try {
          incRPCcallsMetrics();
          request = RequestConverter.buildScanRequest(scannerId, caching, false, nextCallSeq,
                this.scanMetrics != null, renew);
{code}

For {{openScanner}} we have
{code}
    ScanRequest request = RequestConverter.buildScanRequest(
        getLocation().getRegionInfo().getRegionName(), this.scan, 0, false);
{code}
With region info, but other case only
{code}
          request = RequestConverter.buildScanRequest(scannerId, caching, false, nextCallSeq,
                this.scanMetrics != null, renew);
{code}

Correct me if I'm missing something :-)

> Log more details for Scan#next request when responseTooSlow
> -----------------------------------------------------------
>
>                 Key: HBASE-16972
>                 URL: https://issues.apache.org/jira/browse/HBASE-16972
>             Project: HBase
>          Issue Type: Improvement
>          Components: Operability
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-16972.patch
>
>
> Currently for if responseTooSlow happens on the scan.next call, we will get warn log
like below:
> {noformat}
> 2016-10-31 11:43:23,430 WARN  [RpcServer.FifoWFPBQ.priority.handler=5,queue=1,port=60193]
ipc.RpcServer(2574):
> (responseTooSlow): {"call":"Scan(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1477885403428,"responsesize":52,"method":"Scan","param":"scanner_id: 11
number_of_rows: 2147483647
> close_scanner: false next_call_seq: 0 client_handles_partials: true client_handles_heartbeats:
true
> track_scan_metrics: false renew: false","processingtimems":2,"client":"127.0.0.1:60254","queuetimems":0,"class":"HMaster"}
> {noformat}
> From which we only have a {{scanner_id}} and impossible to know what exactly this scan
is about, like against which region of which table.
> After this JIRA, we will improve the message to something like below (notice the last
line):
> {noformat}
> 2016-10-31 11:43:23,430 WARN  [RpcServer.FifoWFPBQ.priority.handler=5,queue=1,port=60193]
ipc.RpcServer(2574):
> (responseTooSlow): {"call":"Scan(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1477885403428,"responsesize":52,"method":"Scan","param":"scanner_id: 11
number_of_rows: 2147483647
> close_scanner: false next_call_seq: 0 client_handles_partials: true client_handles_heartbeats:
true
> track_scan_metrics: false renew: false","processingtimems":2,"client":"127.0.0.1:60254","queuetimems":0,"class":"HMaster",
> "scandetails":"table: hbase:meta region: hbase:meta,,1.1588230740"}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message