hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16972) Log more details for Scan#next request when responseTooSlow
Date Tue, 01 Nov 2016 02:54:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624153#comment-15624153
] 

Yu Li commented on HBASE-16972:
-------------------------------

bq. Does RpcServer have to have direct references to import org.apache.hadoop.hbase.regionserver.RSRpcServices
I'm afraid so, since it's RSRpcServices where the scannerId->RegionScannerHolder mapping
is held, we only have scanner_id for the scan.next call, so we need to get scan details through
such mapping.

bq. and to import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos; though?
The answer is also a Yes here, per above response to Jerry's question, we don't need to do
such parsing for the openScanner call, so we need to check whether the request is ScanRequest,
do some casting, check whether it has a scanner id, and do parsing if so.

Please let me know if you have better idea for the above two places sir, thanks.

> Log more details for Scan#next request when responseTooSlow
> -----------------------------------------------------------
>
>                 Key: HBASE-16972
>                 URL: https://issues.apache.org/jira/browse/HBASE-16972
>             Project: HBase
>          Issue Type: Improvement
>          Components: Operability
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-16972.patch
>
>
> Currently for if responseTooSlow happens on the scan.next call, we will get warn log
like below:
> {noformat}
> 2016-10-31 11:43:23,430 WARN  [RpcServer.FifoWFPBQ.priority.handler=5,queue=1,port=60193]
ipc.RpcServer(2574):
> (responseTooSlow): {"call":"Scan(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1477885403428,"responsesize":52,"method":"Scan","param":"scanner_id: 11
number_of_rows: 2147483647
> close_scanner: false next_call_seq: 0 client_handles_partials: true client_handles_heartbeats:
true
> track_scan_metrics: false renew: false","processingtimems":2,"client":"127.0.0.1:60254","queuetimems":0,"class":"HMaster"}
> {noformat}
> From which we only have a {{scanner_id}} and impossible to know what exactly this scan
is about, like against which region of which table.
> After this JIRA, we will improve the message to something like below (notice the last
line):
> {noformat}
> 2016-10-31 11:43:23,430 WARN  [RpcServer.FifoWFPBQ.priority.handler=5,queue=1,port=60193]
ipc.RpcServer(2574):
> (responseTooSlow): {"call":"Scan(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ScanRequest)",
> "starttimems":1477885403428,"responsesize":52,"method":"Scan","param":"scanner_id: 11
number_of_rows: 2147483647
> close_scanner: false next_call_seq: 0 client_handles_partials: true client_handles_heartbeats:
true
> track_scan_metrics: false renew: false","processingtimems":2,"client":"127.0.0.1:60254","queuetimems":0,"class":"HMaster",
> "scandetails":"table: hbase:meta region: hbase:meta,,1.1588230740"}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message