hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16964) Successfully archived files are not cleared from compacted store file list if archiving of any file fails
Date Thu, 03 Nov 2016 22:38:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634548#comment-15634548
] 

Hudson commented on HBASE-16964:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #66 (See [https://builds.apache.org/job/HBase-1.3-JDK8/66/])
HBASE-16964 Always clear successfully archived files from compacted (garyh: rev 1e4d878325754a6b489843a8bb07c928cd4a2a01)
* (add) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/FailedArchiveException.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MockStoreFile.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveIOException.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Successfully archived files are not cleared from compacted store file list if archiving
of any file fails
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16964
>                 URL: https://issues.apache.org/jira/browse/HBASE-16964
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Blocker
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-16964.002.patch, HBASE-16964.003.patch, HBASE-16964.patch
>
>
> In HStore.removeCompactedFiles(), we only clear archived files from StoreFileManager's
list of compactedfiles if _all_ files were archived successfully.  If we encounter an error
archiving any of the files, then any files which were already archived will remain in the
list of compactedfiles.
> Even worse, this means that all subsequent attempts to archive the list of compacted
files will fail (as the previously successfully archived files still in the list will now
throw FileNotFoundException), and the list of compactedfiles will never be cleared from that
point on.
> Finally, when the region closes, we will again throw an exception out of HStore.removeCompactedFiles(),
in this case causing a regionserver abort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message