hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16962) Add readPoint to preCompactScannerOpen() API
Date Tue, 08 Nov 2016 19:17:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648512#comment-15648512
] 

Enis Soztutar commented on HBASE-16962:
---------------------------------------

I think we should start wrapping these kind of method arguments in {{Context}} objects so
that we do not break the coprocessors everytime we want to add a new parameter or change a
parameter. This way we won't end up with deprecated and overloaded methods. 

Something like: 
{code}
static interface CoprocScannerContext {
  ScanType getScanType(); 
  long getEarliestPutTs(); 
  List<StoreFileScanner> getScanners();
  ...
}
   protected InternalScanner preCreateCoprocScanner(CoprocScannerContext context) throws IOException
{
   }
{code}

> Add readPoint to preCompactScannerOpen() API
> --------------------------------------------
>
>                 Key: HBASE-16962
>                 URL: https://issues.apache.org/jira/browse/HBASE-16962
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Thiruvel Thirumoolan
>            Assignee: Thiruvel Thirumoolan
>         Attachments: HBASE-16962.master.001.patch, HBASE-16962.rough.patch
>
>
> Similar to HBASE-15759, I would like to add readPoint to the preCompactScannerOpen()
API.
> I have a CP where I create a StoreScanner() as part of the preCompactScannerOpen() API.
I need the readpoint which was obtained in Compactor.compact() method to be consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message