hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-16955) Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
Date Tue, 08 Nov 2016 20:52:59 GMT

     [ https://issues.apache.org/jira/browse/HBASE-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack updated HBASE-16955:
    Attachment: 16955.patch

Interesting one. So, failure was in the step before only it wasn't a failure. At the protoc
step, we were doing compile goal. hbase-protocol-shaded needs the install goal to run (shading
is hooked up to the install step). Without it, the protoc generation was left in a half-way

Committed this patch. Let me try my nothing change again now.

> Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
> ----------------------------------------------------------------------------
>                 Key: HBASE-16955
>                 URL: https://issues.apache.org/jira/browse/HBASE-16955
>             Project: HBase
>          Issue Type: Task
>          Components: build, Protobufs
>            Reporter: stack
>            Assignee: stack
>         Attachments: 16955.patch, nothing_change.txt, nothing_change2 (1).txt, nothing_change2
(2).txt, nothing_change2.txt, nothing_change2.txt, nothing_change2.txt, nothing_change2.txt,
nothing_change2.txt, nothing_change2.txt
>  HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs. One, protobufs
are in the module they pertain to so distributed throughout the modules and secondly, we do
2.5.0 pb for externally consumed protobuf -- e.g. Coprocessor Endpoints -- but internally
we use protobuf 3.1.0.
> A precommit check looks to see if any proto changes break protoc compile. This task is
about updating the precommit to accommodate the changes brought about by HBASE-15638.

This message was sent by Atlassian JIRA

View raw message