hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16955) Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
Date Tue, 08 Nov 2016 17:22:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648168#comment-15648168

stack commented on HBASE-16955:

Trying to figure why locally it says:

[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ hbase-protocol-shaded ---
[INFO] Compiling 171 source files to /Users/stack/checkouts/hbase.git/hbase-protocol-shaded/target/classes

... but up on jenkins it is compiling one class only...

> Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
> ----------------------------------------------------------------------------
>                 Key: HBASE-16955
>                 URL: https://issues.apache.org/jira/browse/HBASE-16955
>             Project: HBase
>          Issue Type: Task
>          Components: build, Protobufs
>            Reporter: stack
>            Assignee: stack
>         Attachments: nothing_change.txt, nothing_change2 (1).txt, nothing_change2 (2).txt,
nothing_change2.txt, nothing_change2.txt, nothing_change2.txt, nothing_change2.txt, nothing_change2.txt
>  HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs. One, protobufs
are in the module they pertain to so distributed throughout the modules and secondly, we do
2.5.0 pb for externally consumed protobuf -- e.g. Coprocessor Endpoints -- but internally
we use protobuf 3.1.0.
> A precommit check looks to see if any proto changes break protoc compile. This task is
about updating the precommit to accommodate the changes brought about by HBASE-15638.

This message was sent by Atlassian JIRA

View raw message