hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sudeep Sunthankar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15902) Scan Object
Date Fri, 25 Nov 2016 17:22:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15696348#comment-15696348
] 

Sudeep Sunthankar commented on HBASE-15902:
-------------------------------------------

Thanks [~enis]. Please find my responses below

{quote}
The patch file seems it is only for the second part of two commits
{quote}
I had created this patch on top of Configuration and created both the patches together, which
is why it shows part 2/2. 

{quote}
I don't see changes to BUCK files, so maybe they are there? 
{quote}
I was getting some errors in patching BUCK with the patch created in the manner above, so
I kept BUCK out of the patch and planned on creating a separate patch to hook up the tests.


{quote}
In this patch, we are allocating TimeRange objects in heap via a pointer, versus in the Get
object, we are embedding those objects: 
{quote}
The way it is done in Get creates temporary objects, which is not required. I should have
allocated TimeRange objects in Get on heap as well. I will upload a patch for it as well.

Thanks.

> Scan Object
> -----------
>
>                 Key: HBASE-15902
>                 URL: https://issues.apache.org/jira/browse/HBASE-15902
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-15902.HBASE-14850.patch, HBASE-15902.HBASE-14850.v2.patch
>
>
> Patch for creating Scan objects. Scan objects thus created can be used by Table implementation
to fetch results for a given row.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message