hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15324) Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split
Date Wed, 09 Nov 2016 05:57:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15649904#comment-15649904
] 

Hudson commented on HBASE-15324:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #61 (See [https://builds.apache.org/job/HBase-1.2-JDK8/61/])
HBASE-15324 Jitter may cause desiredMaxFileSize overflow in (esteban: rev 6b8472038dd2632d20fdf8d3216c2fe86ee68580)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java


> Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger
unexpected split
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15324
>                 URL: https://issues.apache.org/jira/browse/HBASE-15324
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.1.3
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.5, 1.1.8
>
>         Attachments: HBASE-15324.patch, HBASE-15324_v2.patch, HBASE-15324_v3.patch, HBASE-15324_v3.patch
>
>
> We introduce jitter for region split decision in HBASE-13412, but the following line
in {{ConstantSizeRegionSplitPolicy}} may cause long value overflow if MAX_FILESIZE is specified
to Long.MAX_VALUE:
> {code}
> this.desiredMaxFileSize += (long)(desiredMaxFileSize * (RANDOM.nextFloat() - 0.5D) *
jitter);
> {code}
> In our case we specify MAX_FILESIZE to Long.MAX_VALUE to prevent target region to split.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message