Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0D263200BB8 for ; Sat, 29 Oct 2016 00:45:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0BF60160AF5; Fri, 28 Oct 2016 22:45:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7B2FF160AE4 for ; Sat, 29 Oct 2016 00:44:59 +0200 (CEST) Received: (qmail 57499 invoked by uid 500); 28 Oct 2016 22:44:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 57485 invoked by uid 99); 28 Oct 2016 22:44:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Oct 2016 22:44:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 56DC22C1F54 for ; Fri, 28 Oct 2016 22:44:58 +0000 (UTC) Date: Fri, 28 Oct 2016 22:44:58 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-16955) Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 28 Oct 2016 22:45:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-16955: -------------------------- Attachment: nothing_change2.txt Retry > Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build > ---------------------------------------------------------------------------- > > Key: HBASE-16955 > URL: https://issues.apache.org/jira/browse/HBASE-16955 > Project: HBase > Issue Type: Task > Components: build, Protobufs > Reporter: stack > Assignee: stack > Attachments: nothing_change.txt, nothing_change2.txt, nothing_change2.txt > > > HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs. One, protobufs are in the module they pertain to so distributed throughout the modules and secondly, we do 2.5.0 pb for externally consumed protobuf -- e.g. Coprocessor Endpoints -- but internally we use protobuf 3.1.0. > A precommit check looks to see if any proto changes break protoc compile. This task is about updating the precommit to accommodate the changes brought about by HBASE-15638. -- This message was sent by Atlassian JIRA (v6.3.4#6332)