Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 24 Oct 2016 06:55:58 +0000 (UTC)
From: "binlijin (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13014625.1477281914000.64424.1477292158383@Atlassian.JIRA>
In-Reply-To: <JIRA.13014625.1477281914000@Atlassian.JIRA>
References: <JIRA.13014625.1477281914000@Atlassian.JIRA> <JIRA.13014625.1477281914338@arcas>
Subject: [jira] [Commented] (HBASE-16931) Setting cell's seqId to zero in
 compaction flow might cause RS down.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 24 Oct 2016 06:56:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16931?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D156=
01166#comment-15601166 ]=20

binlijin commented on HBASE-16931:
----------------------------------

Yes=EF=BC=8Ci do not check the writer, thanks very much for the confirm.

> Setting cell's seqId to zero in compaction flow might cause RS down.
> --------------------------------------------------------------------
>
>                 Key: HBASE-16931
>                 URL: https://issues.apache.org/jira/browse/HBASE-16931
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: binlijin
>            Assignee: binlijin
>            Priority: Critical
>         Attachments: HBASE-16931-master.patch
>
>
> Compactor#performCompaction
>       do {
>         hasMore =3D scanner.next(cells, scannerContext);
>         // output to writer:
>         for (Cell c : cells) {
>           if (cleanSeqId && c.getSequenceId() <=3D smallestReadPoint) {
>             CellUtil.setSequenceId(c, 0);
>           }
>           writer.append(c);
>         }
>         cells.clear();
>       } while (hasMore);
> scanner.next will choose at most "hbase.hstore.compaction.kv.max" kvs, th=
e last cell still reference by StoreScanner.prevCell, so if cleanSeqId is c=
alled when the scanner.next call StoreScanner.checkScanOrder may throw exce=
ption and cause regionserver down.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)