Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 24 Oct 2016 04:27:58 +0000 (UTC)
From: "binlijin (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13014625.1477281914000.63779.1477283278396@Atlassian.JIRA>
In-Reply-To: <JIRA.13014625.1477281914000@Atlassian.JIRA>
References: <JIRA.13014625.1477281914000@Atlassian.JIRA> <JIRA.13014625.1477281914338@arcas>
Subject: [jira] [Commented] (HBASE-16931) Cleaned seqid in compaction should
 set back when write finish.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 24 Oct 2016 04:28:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600904#comment-15600904 ] 

binlijin commented on HBASE-16931:
----------------------------------

And this compaction exception cause 100+ regionservers down in one of our production cluster.

> Cleaned seqid in compaction should set back when write finish.
> --------------------------------------------------------------
>
>                 Key: HBASE-16931
>                 URL: https://issues.apache.org/jira/browse/HBASE-16931
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: binlijin
>            Assignee: binlijin
>
> Compactor#performCompaction
>       do {
>         hasMore = scanner.next(cells, scannerContext);
>         // output to writer:
>         for (Cell c : cells) {
>           if (cleanSeqId && c.getSequenceId() <= smallestReadPoint) {
>             CellUtil.setSequenceId(c, 0);
>           }
>           writer.append(c);
>         }
>         cells.clear();
>       } while (hasMore);
> scanner.next will choose at most "hbase.hstore.compaction.kv.max" kvs, the last cell still reference by StoreScanner.prevCell, so if cleanSeqId is called when the scanner.next call StoreScanner.checkScanOrder may throw exception and cause regionserver down.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)