Return-Path: <issues-return-265585-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 585A1200BB9
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 24 Oct 2016 05:55:00 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 56CB9160AFD; Mon, 24 Oct 2016 03:55:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 9D711160AFC
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 24 Oct 2016 05:54:59 +0200 (CEST)
Received: (qmail 67248 invoked by uid 500); 24 Oct 2016 03:54:58 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 67229 invoked by uid 99); 24 Oct 2016 03:54:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Oct 2016 03:54:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 610132C1F5A
	for <issues@hbase.apache.org>; Mon, 24 Oct 2016 03:54:58 +0000 (UTC)
Date: Mon, 24 Oct 2016 03:54:58 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13014410.1477085309000.63695.1477281298394@Atlassian.JIRA>
In-Reply-To: <JIRA.13014410.1477085309000@Atlassian.JIRA>
References: <JIRA.13014410.1477085309000@Atlassian.JIRA> <JIRA.13014410.1477085309115@arcas>
Subject: [jira] [Commented] (HBASE-16929) Move default method of shipped to
 Shipper interface
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 24 Oct 2016 03:55:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600854#comment-15600854 ] 

stack commented on HBASE-16929:
-------------------------------

Why would you commit something against the Shipped Interface w/o getting input from [~ram_krish]/[~anoop.hbase]?

> Move default method of shipped to Shipper interface
> ---------------------------------------------------
>
>                 Key: HBASE-16929
>                 URL: https://issues.apache.org/jira/browse/HBASE-16929
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0
>
>         Attachments: 16929.v1.txt
>
>
> HBASE-16626 added default method of shipped() to RegionScanner.
> However, when building master branch of Phoenix against 2.0 SNAPSHOT, I got:
> {code}
> [ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java:[27,8] org.apache.phoenix.coprocessor.DelegateRegionScanner is not abstract and does not override  abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper
> [ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:[344,36] <anonymous org.apache.phoenix.coprocessor.BaseScannerRegionObserver$1> is not         abstract and does not override abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper
> {code}
> Here is the snippet for DelegateRegionScanner:
> {code}
> public class DelegateRegionScanner implements RegionScanner {
> {code}
> It seems adding default method in RegionScanner is not enough for downstream projects.
> After moving the default method to Shipper interface, the above two compilation errors are gone in Phoenix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)