Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 20D8D200BB6 for ; Fri, 21 Oct 2016 07:56:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1F906160AF5; Fri, 21 Oct 2016 05:56:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6DBDC160AE0 for ; Fri, 21 Oct 2016 07:55:59 +0200 (CEST) Received: (qmail 95453 invoked by uid 500); 21 Oct 2016 05:55:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95433 invoked by uid 99); 21 Oct 2016 05:55:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Oct 2016 05:55:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6CC9C2C0D52 for ; Fri, 21 Oct 2016 05:55:58 +0000 (UTC) Date: Fri, 21 Oct 2016 05:55:58 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16889) Proc-V2: verifyTables in the IntegrationTestDDLMasterFailover test after each table DDL is incorrect MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 21 Oct 2016 05:56:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-16889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594172#comment-15594172 ] Hudson commented on HBASE-16889: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #55 (See [https://builds.apache.org/job/HBase-1.3-JDK8/55/]) HBASE-16889 Proc-V2: verifyTables in the (syuanjiangdev: rev cd29ea79587ae58711ac33e0f3c60e8368d9686d) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDDLMasterFailover.java > Proc-V2: verifyTables in the IntegrationTestDDLMasterFailover test after each table DDL is incorrect > ----------------------------------------------------------------------------------------------------- > > Key: HBASE-16889 > URL: https://issues.apache.org/jira/browse/HBASE-16889 > Project: HBase > Issue Type: Bug > Components: proc-v2 > Affects Versions: 2.0.0, 1.1.7 > Reporter: Stephen Yuan Jiang > Assignee: Stephen Yuan Jiang > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.4, 1.1.8 > > Attachments: HBASE-16889.v1-branch-1.1.patch, HBASE-16889.v1-master.patch > > > In the IntegrationTestDDLMasterFailover test, verifyTables is called after each table DDL. It iterates 3 lists of tables in ConcurrentHashMap (enabledTables, disabledTables, deletedTables) and tries to do some verification. This is incorrect, eg. a table in enabledTables map could be picked up by DeleteTableAction and is disabled, while the verification tries to check whether table is enabled. This leads to false assertion. > The same for verifyNamespaces(). > The proposed fix is to verify maps only at the end of tests (while no active DDL operation is going on). During test run, we only verify the target table before putting into map. -- This message was sent by Atlassian JIRA (v6.3.4#6332)