Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 85376200BB5 for ; Sat, 22 Oct 2016 20:11:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 83D35160ADB; Sat, 22 Oct 2016 18:11:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D36E6160AE0 for ; Sat, 22 Oct 2016 20:10:59 +0200 (CEST) Received: (qmail 86882 invoked by uid 500); 22 Oct 2016 18:10:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 86861 invoked by uid 99); 22 Oct 2016 18:10:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Oct 2016 18:10:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A22542C2A66 for ; Sat, 22 Oct 2016 18:10:58 +0000 (UTC) Date: Sat, 22 Oct 2016 18:10:58 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16870) Add the metrics of replication sources which were transformed from other dead rs to ReplicationLoad MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 22 Oct 2016 18:11:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15598248#comment-15598248 ] Hudson commented on HBASE-16870: -------------------------------- FAILURE: Integrated in Jenkins build HBase-1.4 #492 (See [https://builds.apache.org/job/HBase-1.4/492/]) HBASE-16870 Add the metrics of replication sources which were (zhangduo: rev d76cc4c1f08d405ea152934a3871758aacc9382f) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationBase.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationLoad.java * (add) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStatus.java > Add the metrics of replication sources which were transformed from other dead rs to ReplicationLoad > --------------------------------------------------------------------------------------------------- > > Key: HBASE-16870 > URL: https://issues.apache.org/jira/browse/HBASE-16870 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0, 1.4.0, 1.2.3, 1.1.7 > Reporter: Guanghao Zhang > Assignee: Guanghao Zhang > Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.2.4, 1.1.8 > > Attachments: HBASE-16870-ADDENDUM-v1.patch, HBASE-16870-ADDENDUM.patch, HBASE-16870-branch-1-v1.patch, HBASE-16870-branch-1-v1.patch, HBASE-16870-branch-1.1-v1.patch, HBASE-16870-branch-1.1-v1.patch, HBASE-16870-branch-1.1.patch, HBASE-16870-branch-1.3-v1.patch, HBASE-16870-branch-1.3-v1.patch, HBASE-16870-branch-1.3.patch, HBASE-16870-branch-1.patch, HBASE-16870-v1.patch, HBASE-16870.patch > > > {code} > private void buildReplicationLoad() { > // get source > List sources = this.replicationManager.getSources(); > List sourceMetricsList = new ArrayList(); > for (ReplicationSourceInterface source : sources) { > if (source instanceof ReplicationSource) { > sourceMetricsList.add(((ReplicationSource) source).getSourceMetrics()); > } > } > // get sink > MetricsSink sinkMetrics = this.replicationSink.getSinkMetrics(); > this.replicationLoad.buildReplicationLoad(sourceMetricsList, sinkMetrics); > } > {code} > The buildReplicationLoad method in o.a.h.h.r.r.Replication didn't consider the replication source which were transformed from other died rs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)