Return-Path: <issues-return-265135-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7CD68200BB6
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 20 Oct 2016 08:52:00 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7B891160ADB; Thu, 20 Oct 2016 06:52:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BCBB8160AE0
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 20 Oct 2016 08:51:59 +0200 (CEST)
Received: (qmail 68613 invoked by uid 500); 20 Oct 2016 06:51:58 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 68570 invoked by uid 99); 20 Oct 2016 06:51:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 06:51:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 79E122C2A66
	for <issues@hbase.apache.org>; Thu, 20 Oct 2016 06:51:58 +0000 (UTC)
Date: Thu, 20 Oct 2016 06:51:58 +0000 (UTC)
From: "Guanghao Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13013135.1476789515000.37087.1476946318496@Atlassian.JIRA>
In-Reply-To: <JIRA.13013135.1476789515000@Atlassian.JIRA>
References: <JIRA.13013135.1476789515000@Atlassian.JIRA> <JIRA.13013135.1476789515214@arcas>
Subject: [jira] [Comment Edited] (HBASE-16870) Add the metrics of
 replication sources which were transformed from other dead rs to
 ReplicationLoad
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 20 Oct 2016 06:52:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591010#comment-15591010 ] 

Guanghao Zhang edited comment on HBASE-16870 at 10/20/16 6:51 AM:
------------------------------------------------------------------

The Hadoop QA result for HBASE-16870-v1.patch seems not right. TestReplicationSmallTests failed in unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/4107/artifact/patchprocess/patch-unit-hbase-server.txt. But the Tests matrix didn't show it......


was (Author: zghaobac):
The Hadoop QA result for HBASE-16870-v1.patch seems not region. TestReplicationSmallTests failed in unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/4107/artifact/patchprocess/patch-unit-hbase-server.txt. But the Tests matrix didn't show it......

> Add the metrics of replication sources which were transformed from other dead rs to ReplicationLoad
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16870
>                 URL: https://issues.apache.org/jira/browse/HBASE-16870
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16870-ADDENDUM.patch, HBASE-16870-branch-1.1.patch, HBASE-16870-branch-1.3.patch, HBASE-16870-branch-1.patch, HBASE-16870-v1.patch, HBASE-16870.patch
>
>
> {code}
>   private void buildReplicationLoad() {
>     // get source
>     List<ReplicationSourceInterface> sources = this.replicationManager.getSources();
>     List<MetricsSource> sourceMetricsList = new ArrayList<MetricsSource>();
>     for (ReplicationSourceInterface source : sources) {
>       if (source instanceof ReplicationSource) {
>         sourceMetricsList.add(((ReplicationSource) source).getSourceMetrics());
>       }
>     }
>     // get sink
>     MetricsSink sinkMetrics = this.replicationSink.getSinkMetrics();
>     this.replicationLoad.buildReplicationLoad(sourceMetricsList, sinkMetrics);
>   }
> {code}
> The buildReplicationLoad method in o.a.h.h.r.r.Replication didn't consider the replication source which were transformed from other died rs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)