Return-Path: <issues-return-264165-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 45B27200BAE
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 14 Oct 2016 07:53:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 4411B160AF9; Fri, 14 Oct 2016 05:53:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 8B30C160AE4
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 14 Oct 2016 07:53:21 +0200 (CEST)
Received: (qmail 30390 invoked by uid 500); 14 Oct 2016 05:53:20 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 30372 invoked by uid 99); 14 Oct 2016 05:53:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Oct 2016 05:53:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 8CCDE2C4C74
	for <issues@hbase.apache.org>; Fri, 14 Oct 2016 05:53:20 +0000 (UTC)
Date: Fri, 14 Oct 2016 05:53:20 +0000 (UTC)
From: "Ashish Singhi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13011858.1476324233000.826532.1476424400573@Atlassian.JIRA>
In-Reply-To: <JIRA.13011858.1476324233000@Atlassian.JIRA>
References: <JIRA.13011858.1476324233000@Atlassian.JIRA> <JIRA.13011858.1476324233702@arcas>
Subject: [jira] [Commented] (HBASE-16821) Enhance LoadIncrementalHFiles to
 convey missing hfiles if any
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 14 Oct 2016 05:53:22 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15574327#comment-15574327 ] 

Ashish Singhi commented on HBASE-16821:
---------------------------------------

{code}
private Pair<Multimap<ByteBuffer, LoadQueueItem>, List<String>> groupOrSplitPhase(
{code}
Update the javadoc for this method.

{code}
protected Pair<List<LoadQueueItem>, String> groupOrSplit(
{code}
You are changing the return type of protected api in a public audience class, is this ok ? Why not add another method instead and keep the existing as it is.

{code}
public List<String> run(String dirPath, Map<byte[], List<Path>> map, TableName tableName) 
{code}
Let it return int only like the other run api, you can move the below logic here.
{code}
List<String> missing = run(dirPath, null, tableName);
if (missing == null) return 0;
return -1;
{code}

Suggest to have a better variable name than missing, may be missingHFiles or something else.

> Enhance LoadIncrementalHFiles to convey missing hfiles if any
> -------------------------------------------------------------
>
>                 Key: HBASE-16821
>                 URL: https://issues.apache.org/jira/browse/HBASE-16821
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16821.v1.txt
>
>
> When map parameter of run() method is not null:
> {code}
>   public int run(String dirPath, Map<byte[], List<Path>> map, TableName tableName) throws Exception{
> {code}
> the caller knows the exact files to be bulk loaded.
> This issue is to enhance the run() API so that when certain hfiles turn out to be missing, the return value should indicate the missing files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)