Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 10 Oct 2016 19:31:20 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13010308.1475795678000.785772.1476127880492@Atlassian.JIRA>
In-Reply-To: <JIRA.13010308.1475795678000@Atlassian.JIRA>
References: <JIRA.13010308.1475795678000@Atlassian.JIRA> <JIRA.13010308.1475795678284@arcas>
Subject: [jira] [Commented] (HBASE-16788) Race in compacted file deletion
 between HStore close() and closeAndArchiveCompactedFiles()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 10 Oct 2016 19:31:22 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563243#comment-15563243 ] 

Ted Yu commented on HBASE-16788:
--------------------------------

bq. t seems problematic to modify the contents of the compactedfiles list (by setting archiving flags on individual files) in getCompactedfiles()

getCompactedfiles() is only called from closeAndArchiveCompactedFiles(). I think it is fine to add the flag.

bq. this code path is only called with the readlock where you don't typically expect mutations to happen
read lock is used in many other places where some mutation happens. e.g.
{code}
  public long add(final Cell cell) {
    lock.readLock().lock();
    try {
       return this.memstore.add(cell);
{code}
FYI


> Race in compacted file deletion between HStore close() and closeAndArchiveCompactedFiles()
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16788
>                 URL: https://issues.apache.org/jira/browse/HBASE-16788
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 1.3.0
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Blocker
>         Attachments: 16788-suggest.v2, HBASE-16788.001.patch, HBASE-16788.002.patch, HBASE-16788_1.patch
>
>
> HBASE-13082 changed the way that compacted files are archived from being done inline on compaction completion to an async cleanup by the CompactedHFilesDischarger chore.  It looks like the changes to HStore to support this introduced a race condition in the compacted HFile archiving.
> In the following sequence, we can wind up with two separate threads trying to archive the same HFiles, causing a regionserver abort:
> # compaction completes normally and the compacted files are added to {{compactedfiles}} in HStore's DefaultStoreFileManager
> # *threadA*: CompactedHFilesDischargeHandler runs in a RS executor service, calling closeAndArchiveCompactedFiles()
> ## obtains HStore readlock
> ## gets a copy of compactedfiles
> ## releases readlock
> # *threadB*: calls HStore.close() as part of region close
> ## obtains HStore writelock
> ## calls DefaultStoreFileManager.clearCompactedfiles(), getting a copy of same compactedfiles
> # *threadA*: calls HStore.removeCompactedfiles(compactedfiles)
> ## archives files in {compactedfiles} in HRegionFileSystem.removeStoreFiles()
> ## call HStore.clearCompactedFiles()
> ## waits on write lock
> # *threadB*: continues with close()
> ## calls removeCompactedfiles(compactedfiles)
> ## calls HRegionFIleSystem.removeStoreFiles() -> HFileArchiver.archiveStoreFiles()
> ## receives FileNotFoundException because the files have already been archived by threadA
> ## throws IOException
> # RS aborts
> I think the combination of fetching the compactedfiles list and removing the files needs to be covered by locking.  Options I see are:
> * Modify HStore.closeAndArchiveCompactedFiles(): use writelock instead of readlock and move the call to removeCompactedfiles() inside the lock.  This means the read operations will be blocked while the files are being archived, which is bad.
> * Synchronize closeAndArchiveCompactedFiles() and modify close() to call it instead of calling removeCompactedfiles() directly
> * Add a separate lock for compacted files removal and use in closeAndArchiveCompactedFiles() and close()


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)