Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 18 Oct 2016 05:38:58 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13010136.1475755797000.13565.1476769138688@Atlassian.JIRA>
In-Reply-To: <JIRA.13010136.1475755797000@Atlassian.JIRA>
References: <JIRA.13010136.1475755797000@Atlassian.JIRA> <JIRA.13010136.1475755797970@arcas>
Subject: [jira] [Commented] (HBASE-16783) Use ByteBufferPool for the header
 and message during Rpc response
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 18 Oct 2016 05:39:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584529#comment-15584529 ] 

ramkrishna.s.vasudevan commented on HBASE-16783:
------------------------------------------------

My only concern was is it ok to add a new API in BBLOS though it is ugly?  
Since BBLOS handles curBuf it is difficult to bring out the buffer management outside without making other APIs also in that new class. 
Else for now can go with BBLOS itself but i fear we may have to do some refactoring later. thanks for the input. Will udpate the patch. 

> Use ByteBufferPool for the header and message during Rpc response
> -----------------------------------------------------------------
>
>                 Key: HBASE-16783
>                 URL: https://issues.apache.org/jira/browse/HBASE-16783
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>         Attachments: HBASE-16783.patch, HBASE-16783_1.patch, HBASE-16783_2.patch, HBASE-16783_3.patch
>
>
> With ByteBufferPool in place we could avoid the byte[] creation in RpcServer#createHeaderAndMessageBytes and try using the Buffer from the pool rather than creating byte[] every time.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)