Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6A837200BA1 for ; Mon, 17 Oct 2016 10:40:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 690E9160AE5; Mon, 17 Oct 2016 08:40:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF4F2160AEC for ; Mon, 17 Oct 2016 10:39:59 +0200 (CEST) Received: (qmail 18339 invoked by uid 500); 17 Oct 2016 08:39:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 18169 invoked by uid 99); 17 Oct 2016 08:39:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Oct 2016 08:39:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7E8F22C4C71 for ; Mon, 17 Oct 2016 08:39:58 +0000 (UTC) Date: Mon, 17 Oct 2016 08:39:58 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16782) Create compaction specific writer that are of type ShipperListener MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 17 Oct 2016 08:40:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-16782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15581605#comment-15581605 ] ramkrishna.s.vasudevan commented on HBASE-16782: ------------------------------------------------ Creating specific writers will help to customise writers for compactions, like for eg. adding a BbPool for the byte[] that gets created in finalizeBlock() can be done only for a compaction write flow alone. > Create compaction specific writer that are of type ShipperListener > ------------------------------------------------------------------ > > Key: HBASE-16782 > URL: https://issues.apache.org/jira/browse/HBASE-16782 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Priority: Minor > Fix For: 2.0.0 > > > In HBASE-16372, there was a discussion around having Compaction specific writers so that only those writers are of type ShipperListener. Though some of the patches attached there was able to do it, still changin StoreFileWriter was affecting MOB and MR as the builder inside it was private. > This improvement JIRA is to ensure all we create compaction specific writers. > For now only the compaciton flow calls ShipperListener#beforeShipped() so should be fine as of now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)