Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 8 Oct 2016 19:41:20 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13009909.1475683495000.774473.1475955680457@Atlassian.JIRA>
In-Reply-To: <JIRA.13009909.1475683495000@Atlassian.JIRA>
References: <JIRA.13009909.1475683495000@Atlassian.JIRA> <JIRA.13009909.1475683495606@arcas>
Subject: [jira] [Commented] (HBASE-16771) VerifyReplication should increase
 GOODROWS counter if re-comparison passes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 08 Oct 2016 19:41:22 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558589#comment-15558589 ] 

Ted Yu commented on HBASE-16771:
--------------------------------

{code}
          Result.compareResults(sourceResult, replicatedResult);
{code}
When the above line doesn't throw exception, the re-comparison passes.
But the row may actually be deleted, leading to empty Result.
GOODROWS counter is not incremented for the above case.

> VerifyReplication should increase GOODROWS counter if re-comparison passes
> --------------------------------------------------------------------------
>
>                 Key: HBASE-16771
>                 URL: https://issues.apache.org/jira/browse/HBASE-16771
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16771.v1.txt, 16771.v2.txt
>
>
> HBASE-16423 added re-comparison feature to reduce false positive rate.
> However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is not incremented. Neither is GOODROWS incremented when re-comparison passes.
> This may produce inconsistent results across multiple runs of the same verifyrep command.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)