Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 5 Oct 2016 05:05:20 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13009628.1475600391000.739196.1475643920707@Atlassian.JIRA>
In-Reply-To: <JIRA.13009628.1475600391000@Atlassian.JIRA>
References: <JIRA.13009628.1475600391000@Atlassian.JIRA> <JIRA.13009628.1475600391146@arcas>
Subject: [jira] [Commented] (HBASE-16761) Migrate existing protobuf2.5.0
 Coprocessor Endpoints (and servers-side hbase) to protobuf3.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 05 Oct 2016 05:05:23 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547689#comment-15547689 ] 

ramkrishna.s.vasudevan commented on HBASE-16761:
------------------------------------------------

+1. Depreciation once we introduce it means we will have imports of both shaded and non-shaded protobuf package thro out 2.0 life cycle.  Better to remove them in 2.1?

> Migrate existing protobuf2.5.0 Coprocessor Endpoints (and servers-side hbase) to protobuf3.
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16761
>                 URL: https://issues.apache.org/jira/browse/HBASE-16761
>             Project: HBase
>          Issue Type: Task
>          Components: Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Priority: Critical
>
> HBase bundles seven or eight coprocessors. These Coprocessor Endpoints (CPEPs) depend currently on protobuf 2.5 and reference protobuf classes at com.google.protobuf.* rather than at the internal relocated location of org.apache.hadoop.hbase.shaded.com.google.protobuf.
> This is issue is about moving our CPEPs to protobuf3.
> I could just replace the protobuf library we depend on making it pb3 but that would break CPEPs that were not shipped as part of hbase core when we install hbase-2.0.0. Over in HBASE-15638 Shade protobuf we did a bunch of work to ensure CPEPs keep working across the upgrade to hbase-2.0.0 so I suggest we just leave our core CPEPs at pb2.5 for now. Rather, lets have a deprecation cycle where we deprecate pb2.5 on the hbase server-side (somehow) for hbase-2.0.0 and then remove pb2.5 in hbase-3.0.0 (or 2.1 or something).
> Would appreciate input on this one. Let me mark this a 2.0.0 critical so it gets some attention before we finish up the 2.0.0 release.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)