Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 74CCF200BD2 for ; Sat, 29 Oct 2016 02:51:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 73B96160AE4; Sat, 29 Oct 2016 00:51:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6822160AF5 for ; Sat, 29 Oct 2016 02:50:59 +0200 (CEST) Received: (qmail 66887 invoked by uid 500); 29 Oct 2016 00:50:58 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 66825 invoked by uid 99); 29 Oct 2016 00:50:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Oct 2016 00:50:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A53202C14F9 for ; Sat, 29 Oct 2016 00:50:58 +0000 (UTC) Date: Sat, 29 Oct 2016 00:50:58 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16743) TestSimpleRpcScheduler#testCoDelScheduling is broke MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 29 Oct 2016 00:51:00 -0000 [ https://issues.apache.org/jira/browse/HBASE-16743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617091#comment-15617091 ] Hudson commented on HBASE-16743: -------------------------------- FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #61 (See [https://builds.apache.org/job/HBase-1.3-JDK8/61/]) HBASE-16743 TestSimpleRpcScheduler#testCoDelScheduling is broke (antonov: rev c542c49ab651989ea85bd43398d95db1833fea26) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java > TestSimpleRpcScheduler#testCoDelScheduling is broke > --------------------------------------------------- > > Key: HBASE-16743 > URL: https://issues.apache.org/jira/browse/HBASE-16743 > Project: HBase > Issue Type: Bug > Components: rpc > Affects Versions: 1.3.0 > Reporter: stack > Assignee: Mikhail Antonov > Fix For: 1.3.0 > > Attachments: HBASE-16743.branch-1.patch > > > The testCoDelScheduling test is broke. Here are some notes on it. I have disabled it in the HBASE-15638 shading patch. > {code} > I don't get this test. When I time this test, the minDelay is > 2 * codel delay from the get go. So we are always overloaded. The test below would seem to complete the queuing of all the CallRunners inside the codel check interval. I don't think we are skipping codel checking. Second, I think this test has been broken since HBASE-16089 Add on FastPath for CoDel went in. The thread name we were looking for was the name BEFORE we updated: i.e. "RpcServer.CodelBQ.default.handler". But same patch changed the name of the codel fastpath thread to: new FastPathBalancedQueueRpcExecutor("CodelFPBQ.default", handlerCount, numCallQueues... > Codel is hard to test. This test is going to be flakey given it all timer-based. Disabling for now till chat > {code} > FYI [~mantonov] -- This message was sent by Atlassian JIRA (v6.3.4#6332)