Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E6AC4200BA6 for ; Tue, 4 Oct 2016 07:24:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E54F4160ADC; Tue, 4 Oct 2016 05:24:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 37010160AE5 for ; Tue, 4 Oct 2016 07:24:22 +0200 (CEST) Received: (qmail 78323 invoked by uid 500); 4 Oct 2016 05:24:20 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 78285 invoked by uid 99); 4 Oct 2016 05:24:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2016 05:24:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 741822C2A5F for ; Tue, 4 Oct 2016 05:24:20 +0000 (UTC) Date: Tue, 4 Oct 2016 05:24:20 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-16741) Amend the generate protobufs out-of-band build step to include shade, pulling in protobuf source and a hook for patching protobuf MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 04 Oct 2016 05:24:23 -0000 [ https://issues.apache.org/jira/browse/HBASE-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack resolved HBASE-16741. --------------------------- Resolution: Fixed Fix Version/s: 2.0.0 Pushed as part of parent commit on 95c1dc93fb6780f66fd8ebb57914a050b75b9b11 The callout to the patch plugin is to do but will file an issue for that when we have our first patch on protobuf. > Amend the generate protobufs out-of-band build step to include shade, pulling in protobuf source and a hook for patching protobuf > --------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-16741 > URL: https://issues.apache.org/jira/browse/HBASE-16741 > Project: HBase > Issue Type: Sub-task > Components: Protobufs > Reporter: stack > Assignee: stack > Fix For: 2.0.0 > > Attachments: 16741.patch > > > As part of the protobuf shading work, I need to amend the build step that builds protobuf sources. For the module used by hbase internally -- the one that has our protos and that does the protobuf shading -- I need to enhance the generate protobuf sources step to also do: > * Shading/relocating so we avoid clashing with protos used by CPEPs out in the hbase-protocol module. > * Pulling down the protobuf lib and including its sources to make IDEs happy else they'll moan about missing (shaded) protobuf. > * A hook that allows us to patch protobuf lib, at least temporarily until our needed changes make it upstream. -- This message was sent by Atlassian JIRA (v6.3.4#6332)