Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B39A3200BB1 for ; Thu, 20 Oct 2016 08:24:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B22E0160AFC; Thu, 20 Oct 2016 06:24:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A152160AEA for ; Thu, 20 Oct 2016 08:24:01 +0200 (CEST) Received: (qmail 29520 invoked by uid 500); 20 Oct 2016 06:24:00 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 29442 invoked by uid 99); 20 Oct 2016 06:23:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2016 06:23:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 9542C2C0073 for ; Thu, 20 Oct 2016 06:23:59 +0000 (UTC) Date: Thu, 20 Oct 2016 06:23:59 +0000 (UTC) From: "Pankaj Kumar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16724) Snapshot owner can't clone MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 20 Oct 2016 06:24:01 -0000 [ https://issues.apache.org/jira/browse/HBASE-16724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590954#comment-15590954 ] Pankaj Kumar commented on HBASE-16724: -------------------------------------- My bad, I will attach attach patch again. thanks Ashish. > Snapshot owner can't clone > -------------------------- > > Key: HBASE-16724 > URL: https://issues.apache.org/jira/browse/HBASE-16724 > Project: HBase > Issue Type: Bug > Components: snapshots > Affects Versions: 2.0.0 > Reporter: Pankaj Kumar > Assignee: Pankaj Kumar > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16724-V2.patch, HBASE-16724-V3.patch, HBASE-16724-branch-1.1.patch, HBASE-16724-branch-1.2.patch, HBASE-16724-branch-1.3.patch, HBASE-16724-branch-1.patch, HBASE-16724.patch > > > Currently only Global admin has the access of cloning a snapshot. > In AccessController, > {code} > @Override > public void preCloneSnapshot(final ObserverContext ctx, > final SnapshotDescription snapshot, final HTableDescriptor hTableDescriptor) > throws IOException { > requirePermission(getActiveUser(ctx), "cloneSnapshot " + snapshot.getName(), Action.ADMIN); > } > {code} > Snapshot owner should be able to clone it, need to add a check like, > {code} > SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)