Return-Path: <issues-return-266314-archive-asf-public=cust-asf.ponee.io@hbase.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 472AD200BBE
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 27 Oct 2016 22:40:00 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 45CD8160AE6; Thu, 27 Oct 2016 20:40:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 9578A160AF6
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 27 Oct 2016 22:39:59 +0200 (CEST)
Received: (qmail 74025 invoked by uid 500); 27 Oct 2016 20:39:58 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 73918 invoked by uid 99); 27 Oct 2016 20:39:58 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 20:39:58 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 8F1F52C14F9
	for <issues@hbase.apache.org>; Thu, 27 Oct 2016 20:39:58 +0000 (UTC)
Date: Thu, 27 Oct 2016 20:39:58 +0000 (UTC)
From: "Gary Helmling (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13003180.1473244085000.109144.1477600798583@Atlassian.JIRA>
In-Reply-To: <JIRA.13003180.1473244085000@Atlassian.JIRA>
References: <JIRA.13003180.1473244085000@Atlassian.JIRA> <JIRA.13003180.1473244085908@arcas>
Subject: [jira] [Commented] (HBASE-16570) Compute region locality in
 parallel at startup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 27 Oct 2016 20:40:00 -0000


    [ https://issues.apache.org/jira/browse/HBASE-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613146#comment-15613146 ] 

Gary Helmling commented on HBASE-16570:
---------------------------------------

If I'm reading this correctly, this change totally circumvents the block location cache that was added in HBASE-14473, and calls FileSystem.getFileBlockLocations() for every store file every time the balancer runs.

In the LoadBalancer.balanceCluster() implementations (in StochasticLoadBalancer, SimpleLoadBalancer), we create a new Cluster instance.

In Cluster.<init>, we call registerRegion() on every HRegionInfo.

In registerRegion(), we do the following:
{code}
        regionLocationFutures.set(regionIndex,
            regionFinder.asyncGetBlockDistribution(region));
{code}

Then, back in Cluster.<init> we do a get() on each ListenableFuture in a loop.

So while we are doing the calls to get block locations in parallel with 5 threads, it looks like we're recomputing them every time balanceCluster() is called and not taking advantage of the cache at all.  Am I misreading something here?  This seems to be a major performance regression for clusters with large numbers of regions/store files.

> Compute region locality in parallel at startup
> ----------------------------------------------
>
>                 Key: HBASE-16570
>                 URL: https://issues.apache.org/jira/browse/HBASE-16570
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: binlijin
>            Assignee: binlijin
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-16570-master_V1.patch, HBASE-16570-master_V2.patch, HBASE-16570-master_V3.patch, HBASE-16570-master_V4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)