Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 15 Oct 2016 06:46:20 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12965573.1462537103000.838737.1476513980465@Atlassian.JIRA>
In-Reply-To: <JIRA.12965573.1462537103000@Atlassian.JIRA>
References: <JIRA.12965573.1462537103000@Atlassian.JIRA> <JIRA.12965573.1462537103111@arcas>
Subject: [jira] [Commented] (HBASE-15789) PB related changes to work with
 offheap
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 15 Oct 2016 06:46:22 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577529#comment-15577529 ] 

Anoop Sam John commented on HBASE-15789:
----------------------------------------

Looks good..  Got the way how we should do the PB patching. Even the new classes in the patch can be inside src/patches/xxx.patch file?  The can make it a complete patch. So when dev download src code and setup in IDE, this step will happen so that they can see these patches classes right?
If it is ok, we can commit this here. Will do the PB PR.

> PB related changes to work with offheap
> ---------------------------------------
>
>                 Key: HBASE-15789
>                 URL: https://issues.apache.org/jira/browse/HBASE-15789
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15789.master.001.patch, HBASE-15789.patch, HBASE-15789_V2.patch
>
>
> This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also depends on the shading of protobuf classes. 
> We should also decide if we are going to fork the PB classes.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)