hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16969) RegionCoprocessorServiceExec should override the toString for logging
Date Sat, 29 Oct 2016 15:30:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15618293#comment-15618293
] 

Hadoop QA commented on HBASE-16969:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 0m 49s {color} | {color:red}
Docker failed to build yetus/hbase:b2c5d84. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12835984/HBASE-16969.branch-1.v0.patch
|
| JIRA Issue | HBASE-16969 |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/4235/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> RegionCoprocessorServiceExec should override the toString for logging
> ---------------------------------------------------------------------
>
>                 Key: HBASE-16969
>                 URL: https://issues.apache.org/jira/browse/HBASE-16969
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.3.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-16969.branch-1.v0.patch, HBASE-16969.v0.patch, HBASE-16969.v1.patch
>
>
> The toString() method is used to log in BatchErrors#makeException.
> {code:title=BatchErrors.java|borderStyle=solid}
> synchronized RetriesExhaustedWithDetailsException makeException(boolean logDetails) {
>   if (logDetails) {LOG.error("Exception occurred! Exception details: " + throwables +
";\nActions: " + actions);
>  }
> {code}
> If RegionCoprocessorServiceExec doesn’t override the toString(), we will see the hash
code in the log message. That message is useless for debugging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message