hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16968) Refactor FanOutOneBlockAsyncDFSOutput
Date Sun, 30 Oct 2016 10:48:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15619743#comment-15619743
] 

Duo Zhang commented on HBASE-16968:
-----------------------------------

StorageType is still placed under org.apache.hadoop.hdfs in hadoop-2.6.x... The old comment
is wrong...

{code}
  // StorageType enum is added in hadoop 2.4, but it is moved to another package in hadoop
2.6 and
  // the setter method in OpWriteBlockProto is also added in hadoop 2.6. So we need to skip
the
  // setStorageType call if it is hadoop 2.5 or before. See createStorageTypeSetter for more
  // details.
  private interface StorageTypeSetter {
    OpWriteBlockProto.Builder set(OpWriteBlockProto.Builder builder, Enum<?> storageType);
  }
{code}

Let me fix...

> Refactor FanOutOneBlockAsyncDFSOutput
> -------------------------------------
>
>                 Key: HBASE-16968
>                 URL: https://issues.apache.org/jira/browse/HBASE-16968
>             Project: HBase
>          Issue Type: Sub-task
>          Components: io, wal
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16968.patch
>
>
> As we have moved to jdk8, and dropped the support of hadoop-2.4.x and hadoop-2.5.x on
master, we could use CompletableFuture instead of CompletionHandler to make the code more
clear, and also remove the support of hadoop-2.4.x and hadoop-2.5.x to remove lots of the
reflection code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message