hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16967) Excluded shaded java classes from findbugs check
Date Sat, 29 Oct 2016 00:22:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617047#comment-15617047
] 

Duo Zhang commented on HBASE-16967:
-----------------------------------

We hava some classes under the shaded package which are written by our own. For example, {{org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil}}.

And we have a {{ForeignExceptionUtil}} class in the hbase-protocol-shaded module so I think
at least we should run findbugs check on this file? Or move this class out of hbase-protocol-shade
module?

Thanks.

> Excluded shaded java classes from findbugs check
> ------------------------------------------------
>
>                 Key: HBASE-16967
>                 URL: https://issues.apache.org/jira/browse/HBASE-16967
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: stack
>
> Carry over from parent issue. [~Apache9] notes that we get findbugs warnings in hbase-protocol-shaded
when a build in this module. The findbugs complaints are about google protobuf that we've
relocated and checked in here. Exclude.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message