hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16955) Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
Date Fri, 28 Oct 2016 23:22:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616917#comment-15616917
] 

Hadoop QA commented on HBASE-16955:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s {color} | {color:blue}
Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s {color} | {color:blue}
The patch file was not named according to hbase's naming conventions. Please see https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for instructions. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 33s {color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 57s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 5s {color} | {color:red}
hbase-protocol-shaded in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 18s {color} | {color:green}
hbase-protocol in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 7s {color} | {color:red}
hbase-protocol-shaded in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 52s {color} | {color:green}
hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s {color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 10s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:7bda515 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12835909/nothing_change2.txt
|
| JIRA Issue | HBASE-16955 |
| Optional Tests |  asflicense  cc  unit  hbaseprotoc  |
| uname | Linux 07044d12f244 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 339017f |
| hbaseprotoc | https://builds.apache.org/job/PreCommit-HBASE-Build/4224/artifact/patchprocess/patch-hbaseprotoc-hbase-protocol-shaded.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4224/artifact/patchprocess/patch-unit-hbase-protocol-shaded.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/4224/testReport/ |
| modules | C: hbase-protocol hbase-protocol-shaded hbase-spark U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/4224/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-16955
>                 URL: https://issues.apache.org/jira/browse/HBASE-16955
>             Project: HBase
>          Issue Type: Task
>          Components: build, Protobufs
>            Reporter: stack
>            Assignee: stack
>         Attachments: nothing_change.txt, nothing_change2.txt, nothing_change2.txt
>
>
>  HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs. One, protobufs
are in the module they pertain to so distributed throughout the modules and secondly, we do
2.5.0 pb for externally consumed protobuf -- e.g. Coprocessor Endpoints -- but internally
we use protobuf 3.1.0.
> A precommit check looks to see if any proto changes break protoc compile. This task is
about updating the precommit to accommodate the changes brought about by HBASE-15638.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message