hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16955) Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
Date Fri, 28 Oct 2016 01:14:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613897#comment-15613897
] 

Duo Zhang commented on HBASE-16955:
-----------------------------------

I think HBASE-16592 is enough to solve this problem?

The problem is the old protobuf plugin can not locate the right protoc executable, but now
we just use the new plugin to manage the protoc executable and do not depend on the external
environment.

> Fixup precommit protoc check to do new distributed protos and pb 3.1.0 build
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-16955
>                 URL: https://issues.apache.org/jira/browse/HBASE-16955
>             Project: HBase
>          Issue Type: Task
>          Components: build, Protobufs
>            Reporter: stack
>            Assignee: stack
>         Attachments: nothing_change.txt
>
>
>  HBASE-15638 Shade protobuf and a follow-ons changed how we do protobufs. One, protobufs
are in the module they pertain to so distributed throughout the modules and secondly, we do
2.5.0 pb for externally consumed protobuf -- e.g. Coprocessor Endpoints -- but internally
we use protobuf 3.1.0.
> A precommit check looks to see if any proto changes break protoc compile. This task is
about updating the precommit to accommodate the changes brought about by HBASE-15638.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message