hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16940) Address review of "Backup/Restore (HBASE-7912, HBASE-14030, HBASE-14123) mega patch" posted on RB
Date Wed, 26 Oct 2016 00:29:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606918#comment-15606918
] 

Ted Yu commented on HBASE-16940:
--------------------------------

Minor comments after brief check.
For BackupSystemTable :
{code}
-        rsTimestampMap.put(server, Long.parseLong(new String(data)));
+        //rsTimestampMap.put(server, Long.parseLong(new String(data)));
+        rsTimestampMap.put(server, Bytes.toLong(data));
{code}
The commented out line can be dropped.
{code}
+    put.addColumn(BackupSystemTable.SESSIONS_FAMILY, Bytes.toBytes("context"), context.toByteArray());
{code}
Line longer than 100 char


> Address review of "Backup/Restore (HBASE-7912, HBASE-14030, HBASE-14123) mega patch"
posted on RB 
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16940
>                 URL: https://issues.apache.org/jira/browse/HBASE-16940
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: HBASE-7912
>
>         Attachments: HBASE-16940-v1.patch
>
>
> Review 52748 remaining issues.
> https://reviews.apache.org/r/52748



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message