hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16929) Move default method of shipped to Shipper interface
Date Sat, 22 Oct 2016 03:39:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597062#comment-15597062
] 

Hudson commented on HBASE-16929:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1830 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1830/])
HBASE-16929 Move default method of shipped to Shipper interface (tedyu: rev ac415f85f3dd0ecf01a655f3b72351a4b5c675bd)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Shipper.java


> Move default method of shipped to Shipper interface
> ---------------------------------------------------
>
>                 Key: HBASE-16929
>                 URL: https://issues.apache.org/jira/browse/HBASE-16929
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0
>
>         Attachments: 16929.v1.txt
>
>
> HBASE-16626 added default method of shipped() to RegionScanner.
> However, when building master branch of Phoenix against 2.0 SNAPSHOT, I got:
> {code}
> [ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionScanner.java:[27,8]
org.apache.phoenix.coprocessor.DelegateRegionScanner is not abstract and does not override
 abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper
> [ERROR] /a/phoenix/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:[344,36]
<anonymous org.apache.phoenix.coprocessor.BaseScannerRegionObserver$1> is not      
  abstract and does not override abstract method shipped() in org.apache.hadoop.hbase.regionserver.Shipper
> {code}
> Here is the snippet for DelegateRegionScanner:
> {code}
> public class DelegateRegionScanner implements RegionScanner {
> {code}
> It seems adding default method in RegionScanner is not enough for downstream projects.
> After moving the default method to Shipper interface, the above two compilation errors
are gone in Phoenix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message