hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16889) Proc-V2: verifyTables in the IntegrationTestDDLMasterFailover test after each table DDL is incorrect
Date Fri, 21 Oct 2016 18:12:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595889#comment-15595889
] 

Hudson commented on HBASE-16889:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.4 #487 (See [https://builds.apache.org/job/HBase-1.4/487/])
HBASE-16889 Proc-V2: verifyTables in the (syuanjiangdev: rev 42e7a4acd7112fde71ca939eaf8225db64a422d2)
* (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestDDLMasterFailover.java


> Proc-V2: verifyTables in the IntegrationTestDDLMasterFailover test after each table DDL
is incorrect 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16889
>                 URL: https://issues.apache.org/jira/browse/HBASE-16889
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>    Affects Versions: 2.0.0, 1.1.7
>            Reporter: Stephen Yuan Jiang
>            Assignee: Stephen Yuan Jiang
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.2.4, 1.1.8
>
>         Attachments: HBASE-16889.v1-branch-1.1.patch, HBASE-16889.v1-master.patch
>
>
> In the IntegrationTestDDLMasterFailover test, verifyTables is called after each table
DDL.  It iterates 3 lists of tables in ConcurrentHashMap (enabledTables, disabledTables, deletedTables)
and tries to do some verification.  This is incorrect, eg. a table in enabledTables map could
be picked up by DeleteTableAction and is disabled, while the verification tries to check whether
table is enabled.  This leads to false assertion.  
> The same for verifyNamespaces().  
> The proposed fix is to verify maps only at the end of tests (while no active DDL operation
is going on).  During test run, we only verify the target table before putting into map.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message