hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16866) Avoid NPE in AsyncRequestFutureImpl#updateStats
Date Tue, 18 Oct 2016 02:03:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584140#comment-15584140
] 

Ted Yu commented on HBASE-16866:
--------------------------------

{code}
980	      if (stat == null) {
981	        LOG.error("No found of any ClientProtos.RegionLoadStats from server:" + server
{code}
Please correct syntax in log.

Modify description to replace NEP.

> Avoid NPE in AsyncRequestFutureImpl#updateStats
> -----------------------------------------------
>
>                 Key: HBASE-16866
>                 URL: https://issues.apache.org/jira/browse/HBASE-16866
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16866.v0.patch
>
>
> If region disables the stats, it won’t response any ClientProtos.RegionLoadStats to
client. So the NEP will happen in AsyncRequestFutureImpl#updateStats.
> We should use relevant log instead of NEP because the data manipulation shouldn’t be
broken by statistics.
> {noformat}
>   protected void updateStats(ServerName server, Map<byte[], MultiResponse.RegionResult>
results) {
>       …
>       ClientProtos.RegionLoadStats stat = regionStats.getValue().getStat();
>       RegionLoadStats regionLoadstats = ProtobufUtil.createRegionLoadStats(stat);
>       …
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message