hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingcheng Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16812) Cleanup deprecated compact() function
Date Thu, 13 Oct 2016 01:30:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570482#comment-15570482
] 

Jingcheng Du commented on HBASE-16812:
--------------------------------------

Thanks a lot [~appy]. I can take this JIRA to cleanup the deprecated compact() method.
bq. If compaction tool triggers compact, then no locks are being taken.
Actually the lock is taken in CompactionTool, because we do this in {{DefaultMobStoreCompactor.compact}}.
Now we don't have mob compaction in CompactionTool, but how about adding it in another jira,
and only do cleanup in this jira?
bq. If ExpiredMobFileCleaner is triggered from command line, then no locks are taken.
We take read lock here too to synchronize this operation with mob and major compaction.

> Cleanup deprecated compact() function
> -------------------------------------
>
>                 Key: HBASE-16812
>                 URL: https://issues.apache.org/jira/browse/HBASE-16812
>             Project: HBase
>          Issue Type: Task
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>         Attachments: HBASE-16812.master.001.patch
>
>
> compact(CompactionContext compaction, CompactionThroughputController throughputController)
is [deprecated in 1.2.0 release|https://github.com/apache/hbase/blob/rel/1.2.0/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java#L222].
> Store.java is also marked limited private.
> Context: I was cleaning up zk table lock which is also used in that method's [override|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java#L460]
in HMobStore.
> This method isn't being called from anywhere except CompactionTool (which creates HStore
object, not HMobStore object).
> [~jingcheng.du@intel.com] Can you PTAL and help me understand what's going on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message