hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16783) Use ByteBufferPool for the header and message during Rpc response
Date Fri, 14 Oct 2016 11:11:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575016#comment-15575016
] 

ramkrishna.s.vasudevan commented on HBASE-16783:
------------------------------------------------

Now this patch creates a BBPoolManager (any better name?) whose primary aim is to manage the
buffers allocated from the pool and that are created out of pool. 
We could add APIs to this class which will be helping us in the BBPool that we wil be using
in the write requests side.
There we need a ByteBuff based buffers so that that can be used with ByteBuff based CIS. So
if we can use this manager all the code related to byte buffer management will be self contained.
I had a patch for that but since write side is not done, will do it along with those sub tasks.

> Use ByteBufferPool for the header and message during Rpc response
> -----------------------------------------------------------------
>
>                 Key: HBASE-16783
>                 URL: https://issues.apache.org/jira/browse/HBASE-16783
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>         Attachments: HBASE-16783.patch, HBASE-16783_1.patch, HBASE-16783_2.patch
>
>
> With ByteBufferPool in place we could avoid the byte[] creation in RpcServer#createHeaderAndMessageBytes
and try using the Buffer from the pool rather than creating byte[] every time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message