hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16783) Use ByteBufferPool for the header and message during Rpc response
Date Tue, 18 Oct 2016 04:36:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584426#comment-15584426
] 

ramkrishna.s.vasudevan commented on HBASE-16783:
------------------------------------------------

bq. But this new class should not be responsible check size and do any sort of writes or so.
I agree to this. This patch as I said the BBoolManager is not doing more that what it is supposed
to do. 
But if there is one person managing the pool for the current read request it is better it
knows what is the current buffer active.
So if allow the BBLOS to accept a pool and have the curBuf getting updated in the BBLOS, now
if I need to get the curBuf only for someother operation if there is enough remaining length
in the curBuf how should it be done?  Because the entire logic of curBuf updation is self
contained in BBLOS now.

> Use ByteBufferPool for the header and message during Rpc response
> -----------------------------------------------------------------
>
>                 Key: HBASE-16783
>                 URL: https://issues.apache.org/jira/browse/HBASE-16783
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>         Attachments: HBASE-16783.patch, HBASE-16783_1.patch, HBASE-16783_2.patch, HBASE-16783_3.patch
>
>
> With ByteBufferPool in place we could avoid the byte[] creation in RpcServer#createHeaderAndMessageBytes
and try using the Buffer from the pool rather than creating byte[] every time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message