hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16771) VerifyReplication should increase GOODROWS counter if re-comparison passes
Date Sat, 08 Oct 2016 20:01:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558617#comment-15558617

Josh Elser commented on HBASE-16771:

bq.  But the row may actually be deleted, leading to empty Result.

Gotcha. Thanks for the explanation!

So, the first time we checked the row, it was deleted in the source, but that was not yet
propagated to the destination. On the re-verification, it was deleted in both source and destination,
so we only increment GOODROWS when the source row is non-empty. Makes sense!

> VerifyReplication should increase GOODROWS counter if re-comparison passes
> --------------------------------------------------------------------------
>                 Key: HBASE-16771
>                 URL: https://issues.apache.org/jira/browse/HBASE-16771
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 16771.v1.txt, 16771.v2.txt
> HBASE-16423 added re-comparison feature to reduce false positive rate.
> However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is not incremented.
Neither is GOODROWS incremented when re-comparison passes.
> This may produce inconsistent results across multiple runs of the same verifyrep command.

This message was sent by Atlassian JIRA

View raw message