hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16769) Deprecate/remove PB references from MasterObserver and RegionServerObserver
Date Thu, 06 Oct 2016 09:17:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551425#comment-15551425
] 

ramkrishna.s.vasudevan commented on HBASE-16769:
------------------------------------------------

Going thro those RegionServerObserver hooks where the WALEntry is the only protos based parameter,
it seems it is unused currently. So it could be safer to remove them? 
But the same cannot be applied to all.
Yes, coming to Client interfaces like Puts/Scans we do create POJO from PB/to PB and use them
just because our hooks expect the hbase interfaces rather than protos based.
In that sense changing such CP hooks should be better than leaving it with the protos style.

> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-16769
>                 URL: https://issues.apache.org/jira/browse/HBASE-16769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
> 	preListSnapshot
> 	postListSnapshot
> 	preSnapshot
> 	postSnapshot
> 	preCloneSnapshot
> 	postCloneSnapshot
> 	preRestoreSnapshot
> 	postRestoreSnapshot
> 	preDeleteSnapshot
> 	postDeleteSnapshot
> 	
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetTableQuota
> 	postSetTableQuota
> 	preSetNamespaceQuota
> 	postSetNamespaceQuota
> 	
> RegionServerObserver
> 	preReplicateLogEntries
> 	postReplicateLogEntries



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message