hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16758) Bring back HBaseZeroCopyByteStringer stuff
Date Wed, 05 Oct 2016 05:39:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547746#comment-15547746
] 

ramkrishna.s.vasudevan commented on HBASE-16758:
------------------------------------------------

So the above classes are either CPs, EPs or HDFS related ones where we can't apply shading?
If not we could have gone with UnsafeByteOperations only?
+1 then.

> Bring back HBaseZeroCopyByteStringer stuff
> ------------------------------------------
>
>                 Key: HBASE-16758
>                 URL: https://issues.apache.org/jira/browse/HBASE-16758
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Protobufs
>    Affects Versions: 2.0.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16758.patch
>
>
> After the shading and moving to 3.x PB, we dont need this. But many a places, we can
not use the shaded classes. (Like FanOutOneBlockAsyncDFSOutputSaslHelper).  In those places
it will be better to go with old way of HBaseZeroCopyByteStringer fix to avoid copy.
> Need to see where all we need to do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message