hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HBASE-16741) Amend the generate protobufs out-of-band build step to include shade, pulling in protobuf source and a hook for patching protobuf
Date Tue, 04 Oct 2016 05:24:20 GMT

     [ https://issues.apache.org/jira/browse/HBASE-16741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack resolved HBASE-16741.
---------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Pushed as part of parent commit on 95c1dc93fb6780f66fd8ebb57914a050b75b9b11

The callout to the patch plugin is to do but will file an issue for that when we have our
first patch on protobuf.

> Amend the generate protobufs out-of-band build step to include shade, pulling in protobuf
source and a hook for patching protobuf
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16741
>                 URL: https://issues.apache.org/jira/browse/HBASE-16741
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Protobufs
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 16741.patch
>
>
> As part of the protobuf shading work, I need to amend the build step that builds protobuf
sources. For the module used by hbase internally -- the one that has our protos and that does
the protobuf shading -- I need to enhance the generate protobuf sources step to also do:
>  * Shading/relocating so we avoid clashing with protos used by CPEPs out in the hbase-protocol
module.
>  * Pulling down the protobuf lib and including its sources to make IDEs happy else they'll
moan about missing (shaded) protobuf.
>  * A hook that allows us to patch protobuf lib, at least temporarily until our needed
changes make it upstream.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message