hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
Date Fri, 14 Oct 2016 23:49:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576914#comment-15576914
] 

Hudson commented on HBASE-16729:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #1787 (See [https://builds.apache.org/job/HBase-Trunk_matrix/1787/])
HBASE-16729 Define the behavior of (default) empty FilterList(ChiaPing (ramkrishna: rev 635ea05b9a975c13916148081754fa842adfb54a)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterList.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java


> Define the behavior of (default) empty FilterList
> -------------------------------------------------
>
>                 Key: HBASE-16729
>                 URL: https://issues.apache.org/jira/browse/HBASE-16729
>             Project: HBase
>          Issue Type: Wish
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Trivial
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16729.v0.patch, HBASE-16729.v1.patch, HBASE-16729.v2.patch,
HBASE-16729.v3.patch
>
>
> Current empty FilterList filters all data, because the FilterList#isFamilyEssential always
returns false which causes the null cell retrieved by RegionScannerImpl.storeHeap.
> It seems to me that empty FilterList should do nothing, because the following code is
common.
> {noformat}
> private static Filter makeFilter() {
>   FilterList filterList = new FilterList ();
>   for (some conditions) {
>     // add some filters. Or nothing to add.
>   }
>   return filterList;
> }
> {noformat}
> If we keep the current logic which filters all data, we should add enough comments to
explain it. Or add the FilterList#size() or FilterList#empty() for preventing filtering all
data.
> Any comments? Thanks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message