hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16729) Define the behavior of (default) empty FilterList
Date Thu, 13 Oct 2016 16:35:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572437#comment-15572437

ramkrishna.s.vasudevan commented on HBASE-16729:

Ping [~saint.ack@gmail.com] and [~lhofhansl]. What do you think with respect to this comment?
bq.Instead of any change, we can just add enough comments to explain the empty FilterList.
It seems to me that the issue of empty FilterList is the inconsistent result(see HBASE-16731).
Do you reckon marking this as incompatible change as done in this patch or just a doc is enough?
Seems [~chia7712] has run into issues because of empty filter list. So I felt changing the
behaviour and having the write behaviour is better than just doc update.

> Define the behavior of (default) empty FilterList
> -------------------------------------------------
>                 Key: HBASE-16729
>                 URL: https://issues.apache.org/jira/browse/HBASE-16729
>             Project: HBase
>          Issue Type: Wish
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Trivial
>         Attachments: HBASE-16729.v0.patch
> Current empty FilterList filters all data, because the FilterList#isFamilyEssential always
returns false which causes the null cell retrieved by RegionScannerImpl.storeHeap.
> It seems to me that empty FilterList should do nothing, because the following code is
> {noformat}
> private static Filter makeFilter() {
>   FilterList filterList = new FilterList ();
>   for (some conditions) {
>     // add some filters. Or nothing to add.
>   }
>   return filterList;
> }
> {noformat}
> If we keep the current logic which filters all data, we should add enough comments to
explain it. Or add the FilterList#size() or FilterList#empty() for preventing filtering all
> Any comments? Thanks.

This message was sent by Atlassian JIRA

View raw message